Skip to content

vmware: add support for VMware 6.7#3413

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:vmware-67
Jun 25, 2019
Merged

vmware: add support for VMware 6.7#3413
yadvr merged 1 commit into
apache:masterfrom
shapeblue:vmware-67

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Jun 20, 2019

This adds support for VMware 6.7
Fixes #2700

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Was able to deploy an advanced zone with VMware vCenter/ESXi 6.7 and see systemvms come up:
Screenshot from 2019-06-21 03-08-59

@yadvr
vmware: add support for VMware 6.7
9f59773 
This adds support for VMware 6.7
Fixes apache#2700

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Jun 20, 2019
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 20, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr yadvr self-assigned this Jun 20, 2019
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2918

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 20, 2019

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 20, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 21, 2019

Trillian test result (tid-3715)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30362 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3413-t3715-vmware-65u2.zip
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 25, 2019

@PaulAngus @andrijapanic @borisstoyanov @anuragaw @shwstppr @nvazquez please review

shwstppr
shwstppr approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code

anuragaw
anuragaw approved these changes Jun 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Code wise but haven't tested)

@yadvr yadvr merged commit 1ef0598 into apache:master Jun 25, 2019
@nvazquez nvazquez mentioned this pull request Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@andrijapanicsb andrijapanicsb Awaiting requested review from andrijapanicsb

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

@nvazquez nvazquez Awaiting requested review from nvazquez

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

+1 more reviewer

@anuragaw anuragaw anuragaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yadvr yadvr

Labels

component:vmware

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

Add support to vCenter/vSphere 6.7

4 participants

@yadvr @blueorangutan @shwstppr @anuragaw